fix(comp:tabs): offset error when setting selectedKey #1236
+65
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 93.01% 93.03% +0.01%
==========================================
Files 317 317
Lines 29136 29149 +13
Branches 3307 3307
==========================================
+ Hits 27101 27118 +17
+ Misses 2035 2031 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
liuzaijiang
force-pushed
the
fix-tabs-lzj
branch
from
6df92e0
to
c90ea23
Compare
danranVm
approved these changes
Oct 28, 2022
|
@liuzaijiang 测试挂了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
当存在滚动条时，首次设置selectedKey，无法滚动到相应位置
What is the new behavior?
功能正常
Other information
新增tabs时滚动位置由用户指定的selectedKey来决定偏移位置，内部不进行处理